Debug Info #86
Merged
Debug Info #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good so far! One small nit: I think |
|
The operative verb in all of the DI bindings is "create" instead of "build". Should we match LLVM or our IRBuilder? |
|
So I think the difference is that IRBuilder builds instructions in a scope, while DIBuilder creates types/relationships/metadata that are attached to instructions. So I think |
segiddins
reviewed
Apr 18, 2017
Sources/LLVM/DIBuilder.swift
Outdated
| @@ -362,6 +362,30 @@ public enum DWARFTypeEncoding { | |||
| case ucs | |||
|
|
|||
| case ascii | |||
|
|
|||
| static let typeEncodingMapping: [DWARFTypeEncoding: LLVMDWARFTypeEncoding] = [ | |||
There was a problem hiding this comment.
should this maybe be private?
Sources/LLVM/DIBuilder.swift
Outdated
| } | ||
|
|
||
| /// Create a new descriptor for a parameter variable. | ||
| public func createParameterVariable(in scope: Scope, named name: String, at index: UInt32, in file: FileMetadata, at line: Int, type: DIType, _ alwaysPreserve: Bool = true, flags: DebugInfoFlags = .zero) -> VariableMetadata { |
There was a problem hiding this comment.
Let's make all the indices Ints. Swift stdlib did this too.
CodaFi
force-pushed
the
mushi-mushi
branch
3 times, most recently
from
8e9c7e3 to
122036c
Compare
CodaFi
force-pushed
the
mushi-mushi
branch
4 times, most recently
from
0870807 to
b42ddf6
Compare
|
⛵️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.